Convert it translations from solidus 1.2 -> 1.3 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luukveenis
force-pushed
the
update-it-translations
branch
from
1f3f025
to
8a88084
Compare
config/locales/it.yml
Outdated
| @@ -23,6 +25,7 @@ it: | |||
| iso_name: Nome ISO | |||
| name: Nome | |||
| numcode: Codice ISO | |||
| states_required: Stati Necessari | |||
There was a problem hiding this comment.
this should be "Provincia Necessaria"
|
@mtylty and @alepore it would be very great, if you open a pr against @luukveenis branch, so we can merge this into it. Thanks for your help. |
|
@tvdeyen it will be done! |
| default_tax: Zona di Tassazione di Default | ||
| spree/adjustment: | ||
| adjustable: Variabile | ||
| amount: Quantità |
There was a problem hiding this comment.
good catch. this probably needs to be checked in the admin...
|
@AlessioRocco @mtylty @alepore could you please have a look at #62 ? Thanks |
|
@luukveenis any new on this? |
luukveenis
force-pushed
the
update-it-translations
branch
from
d11085e
to
2b8b5ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes made to admin translations in solidus moved many of the keys. This was done to better use the ActiveModel translation conventions.
I wrote a script that scans through the locale files in solidus_i18n looking for missing keys when compared to
en.ymlin core. Since these translations are just moved, the script attempts to make the same moves in this locale as were made for english.Reviews would be appreciated to find any blatant mistranslations.