-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing russian translations & corrections in russian translations #6
Conversation
@@ -1096,7 +1097,8 @@ ru: | |||
reference: "Ссылка" | |||
refund: "Возврат" | |||
refund_amount_must_be_greater_than_zero: | |||
refund_reasons: "Причины возврата" | |||
refund_reasons: "Причины возврата денег" | |||
return_reasons: "Причины возврата товара" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This second translation has the same translation key. Which one is the correct one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 1100 is correct. In Russian there is a common word used for all kinds of return (money, product). In English we use "refund" for money and "return" for a product. In Russian usually used one word - "Return" + clarification (what kind of return is it), return of a product (Причины возврата товара) or refund (Причины возврата денег). So, additional word is clarification that is needed in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 1280 is better, basically the meaning is same, but it's shorter, it doesn't deface header's navigation menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. But you have two translations for refund_reasons
now. Could you please remove one of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no duplicated lines, they are two different lines:
1099 was wrong
1101 is a new one (I have added this one because it was missing translation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, excuse me. I didn't saw the difference between refund_reasons
and return_reasons
. Could you please put return_reasons
into correct alphabetical order? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries,
now order is alphabetical (f, t)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe my github has an old cache, but it's not in the correct alphabetical order.
As we use the original en.yml
from solidus core as reference, would you please add translation key at the same position as in the original one?
https://github.com/solidusio/solidus/blob/master/core/config/locales/en.yml#L1299
Thanks for your understanding and your contribution 🌷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@connecticus would you mind to check the order again? As commented above, your proposed changes are not reflected here on GitHub.
Thanks for contributing. Please check the duplicate translation. |
small improvements in .ru