Explicitly use full constant name in locale helper

[tvdeyen]

Sometimes Rails Module lockup causes errors like in #73

Closes #73

[fschwahn]

@tvdeyen rails autoloading usually (or by default) does not include the lib directory, only stuff in app is autoloaded. I think the better way to fix this would be to just require this file in lib/solidus_i18n.rb.

[tvdeyen]

@fschwahn good catch! Will do. Thanks for the heads up

[mamhoff]

Looks good to me. In #73, though, the OP said this does not solve his problem, did you verify it did? His comment is ten days old, and I think your PR got recently updated.

[fschwahn]

@tvdeyen @mamhoff you can reproduce this issue by putting config.cache_classes = true and config.eager_load = true (ie. disable autoloading) and visiting "/en/admin/general_settings/edit".

[mamhoff]

@fschwahn If you tell me it fixes your issue, I'll trust you on it.

[fschwahn]

Yes, this fixes the issue, but the change to LocaleHelper is not necessary, just the require.

[tvdeyen]

but the change to LocaleHelper is not necessary

I know, but it is not harmful and even better to avoid strange Rails module namespace lookup issues like in solidusio/solidus#1615

[fschwahn]

Yes, you're right