New translations update tasks #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The file download was not working - Download the file under /config/locales
tvdeyen
approved these changes
May 22, 2017
solidus_i18n.gemspec
Outdated
| @@ -40,4 +40,5 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'rubocop', '>= 0.24.1' | |||
| s.add_development_dependency 'rspec-rails', '~> 3.1' | |||
| s.add_development_dependency 'simplecov', '~> 0.9' | |||
| s.add_development_dependency 'i18n-tasks', '~> 0.9.15' | |||
There was a problem hiding this comment.
I'm sure we can remove the lock to the patch version and only lock to the minor version instead.
This gem can replace our custom, old and untested tasks for Yaml files management. This is not compatible with older solidus versions but that's not a problem. We only need this when using the master branch.
Remove the old code of the solidus_i18n:sync task and document the use of i18n-tasks.
|
Ok i solved the bundle problem (makes sense to only use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some rake tasks to manage YAML files: getting the latest master
en.ymland updating other languages with the missing keys.The tasks actually doesn't work and there's a quite of text parsing code that is not tested.
I think no one has used them for years.
This PR removes that code and uses the
i18n-tasksto accomplish the YAML sync feature.i18n-tasksseems a good gem, has tests and does a lot of other things we can use in the future.A similar work was done years ago on spree (spree-contrib/spree_i18n#640) but was never merged.