This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Update to Solidus 3.0 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinasMazar
force-pushed
the
mm/solidus-3.0
branch
5 times, most recently
from
c198c5b to
50934a3
Compare
MinasMazar
force-pushed
the
mm/solidus-3.0
branch
4 times, most recently
from
c3dd393 to
c09a16b
Compare
The minimum version is now 0.8.1 as it includes the utility method `SolidusSupport.combined_first_and_last_name_in_address?` that is used in order to understand whether to use the name attribute or the old firstname and lastname.
probably this is necessary with rspec-rails 4.x
On recent Solidus version the `::Spree::Preferences::Persistable` module must be explicitly included in order to use preferences.
Use the already existent `SolidusPaypalbraintree::Address` service class as a wrapper around `Spree::Address` which is responsible to respond to both firstname/lastname and name methods, in order to be compatible with all Solidus versions. - fix factories - check for other fields rather than full_name/name on expectations, in order to work on all Solidus versions. Co-authored-by: Andrea Longhi <andrea@spaghetticode.it> Co-authored-by: Flavio Auciello <flavioauciello@nebulab.it>
We're still supporting Solidus 2.9 and 2.10, but since 2.11 we can rely on the presence of `Spree::Address::Name` for name manipulations.
The method does not depend on the instance, plus this way it can be easily reused elsewhere.
This seems a better place for defining this method as it deals with the address model name.
According to [Braintree 3D Secure doc][1] the 'region' parameter now doesn't accept state's name anymore, but abbreviation. [1]: https://developers.braintreepayments.com/guides/3d-secure/client-side/javascript/v3#using-3ds Co-authored-by: Andrea Longhi <andrea@spaghetticode.it> Co-authored-by: Flavio Auciello <flavioauciello@nebulab.it>
Co-authored-by: Andrea Longhi <andrea@spaghetticode.it> Co-authored-by: Flavio Auciello <flavioauciello@nebulab.it>
spaghetticode
force-pushed
the
mm/solidus-3.0
branch
from
c09a16b to
75e011d
Compare
Ruby 2.4 is not supported by Rubocop since 1.12, and Solidus is currently supporting Ruby >= 2.5.
spaghetticode
force-pushed
the
mm/solidus-3.0
branch
from
48b7d50 to
2f7370e
Compare
kennyadsl
reviewed
Apr 26, 2021
| address.name = name | ||
| if SolidusSupport.combined_first_and_last_name_in_address? | ||
| address.name = begin | ||
| if first_name.nil? |
There was a problem hiding this comment.
Why this check? In Solidus 2.11 we'll have both first_name and name always synced and this is probably always false. In Solidus 3, there's no reason to check first_name, which is no more used.
There was a problem hiding this comment.
Here first_name is an instance attribute of SolidusPaypalBraintree::TransactionAddress (together with last_name and name). If I recall correctly these values are returned by Braintree itself and maybe they can be valorized differently according to the API version (that's why we need the check on its presence).
kennyadsl
approved these changes
Apr 26, 2021
This was referenced Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the extension work with Solidus 3.0.
Adjust code related to
Spree::Addressto fit the new combined first and last name behaviour; it also update some dependency and lint rules.