Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for C2 country code for China #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtapia
Copy link
Contributor

@jtapia jtapia commented Oct 16, 2023

Summary

As selecting China from PayPal addresses, the country_code that we received is C2, and that doesn't match with the Carmen/Spree::Country default code for China(CN)

=> #<ActionController::Parameters {"city"=>"Beijing", "state"=>"BEIJING", "country_code"=>"C2", "postal_code"=>"100000"} permitted: false>

@jtapia jtapia force-pushed the country/fix-c2-code branch from 396e8ac to 896e792 Compare October 16, 2023 06:14
@kennyadsl
Copy link
Member

@jtapia can you please rebase this one? The failure should be gone now, thanks!

@jtapia jtapia force-pushed the country/fix-c2-code branch from 896e792 to 23af249 Compare December 31, 2023 04:15
@tvdeyen tvdeyen force-pushed the country/fix-c2-code branch from 23af249 to a8f02bd Compare December 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants