Add docker-compose environment #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a new commit adapting the sandbox app generator so that it takes into account the configured database credentials. It makes it work out of the box with the docker setup (or, in fact, any other local setup where the environment variables have been configured). |
waiting-for-dev
force-pushed
the
waiting-for-dev/docker
branch
from
f210526 to
5a0f9b5
Compare
waiting-for-dev
force-pushed
the
waiting-for-dev/docker
branch
from
5a0f9b5 to
9ba845a
Compare
See solidusio/solidus#3947 for details on the decisions that have been taken. We are also decoupling the source of solidus & solidus_i18n dependencies, and providing more flexibility by allowing the specification of both repository & branch for each project (therefore allowing working with forks).
waiting-for-dev
force-pushed
the
waiting-for-dev/docker
branch
from
9ba845a to
0bba5ad
Compare
|
Hey @kennyadsl, it should be ready for merge. Now that solidusio/solidus#3947 has been merged, we can proceed with this one. I just updated the code to point to master on solidus. |
|
Taking a look at the compare failure, I will merge anyway once I get why it's failing (if it's not related). |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See solidusio/solidus#3947 for details on the decisions that have been
taken.
We are also decoupling the source of solidus & solidus_i18n
dependencies, and providing more flexibility by allowing the
specification of both repository & branch for each project (therefore
allowing working with forks).
This is WIP until solidusio/solidus#3947 is merged. Until then we're relying on the PR's branch to make it work.
Types of changes
Checklist: