System specs #22
Merged
System specs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocknotes
force-pushed
the
mr/system-specs
branch
10 times, most recently
from
e128e2e to
ad2bd12
Compare
kennyadsl
reviewed
Mar 6, 2020
blocknotes
force-pushed
the
mr/system-specs
branch
3 times, most recently
from
1f0b57f to
e2d19a6
Compare
blocknotes
force-pushed
the
mr/system-specs
branch
from
e2d19a6 to
0c710af
Compare
blocknotes
force-pushed
the
mr/system-specs
branch
from
0c710af to
ce16b45
Compare
blocknotes
force-pushed
the
mr/system-specs
branch
2 times, most recently
from
7fffb72 to
1127f81
Compare
kennyadsl
reviewed
Apr 6, 2020
blocknotes
force-pushed
the
mr/system-specs
branch
from
f9657fb to
a78b3f6
Compare
kennyadsl
reviewed
Apr 10, 2020
blocknotes
force-pushed
the
mr/system-specs
branch
2 times, most recently
from
00e231d to
3d753a3
Compare
blocknotes
force-pushed
the
mr/system-specs
branch
from
3d753a3 to
c77b3f0
Compare
Set the browser to use for system specs explicitly.
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
blocknotes
force-pushed
the
mr/system-specs
branch
from
c77b3f0 to
527ca4d
Compare
CAPYBARA_DRIVER for no js specs. CAPYBARA_JS_DRIVER for js specs.
blocknotes
force-pushed
the
mr/system-specs
branch
from
9b5dcb2 to
19606c9
Compare
|
Rebased, added a new commit to permit to check the Capybara driver via env variables, made some more checks. Ready to merge for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from feature specs to system specs.
Details here:
https://relishapp.com/rspec/rspec-rails/docs/system-specs/system-spec
Fixes #19