Refactor create_profile to use Stripe gem #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brchristian
changed the title
create_profile to use Stripe gem
brchristian
force-pushed
the
stripe_gem_create_profile
branch
from
762aae8 to
49ab060
Compare
brchristian
force-pushed
the
stripe_gem_create_profile
branch
3 times, most recently
from
3acf921 to
77f2b5f
Compare
brchristian
force-pushed
the
stripe_gem_create_profile
branch
from
77f2b5f to
35b2cf1
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a replacement / extension for the work in #77. It can commit cleanly if #77 is merged, or alternately #77 can be closed and this PR can take its place.
Changes from #77:
create_profilemethod, a stepping stone to the long-term goal of Roadmap to remove ActiveMerchant dependency? #74.I’m very pleased with this result.
@spaghetticode Your code review of #77 was amazing, and I incorporated all of your suggestions there into this PR as well. What do you think?