Update the PDP subscription form #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the subscription PDP additional fields removing some strange behaviur. Show the form only if the product or the one of the product variants are subscribable. Use the PDP quantity field to set the subscription quantity. Add default values for the interval units fields. Set the selected variant for the subscribable id.
|
@vassalloandrea thanks, what about adding some specs for the behavior change? |
stefano-sarioli
requested review from
aldesantis and
kennyadsl
and removed request for
aldesantis
|
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this for lack of activity, but feel free to reopen if you have time to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #243
Fix the subscription PDP additional fields removing some strange behaviur. Show the form only if the product or the one of the product variants are subscribable.
Use the PDP quantity field to set the subscription quantity.
Add default values for the interval units fields.
Set the selected variant for the subscribable id.
Result: