Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally version sqlite3 gem #316

Closed
wants to merge 4 commits into from

Conversation

mamhoff
Copy link
Collaborator

@mamhoff mamhoff commented Jan 14, 2025

Older versions of Rails, and thus older versions of Solidus, are incompatible with the sqlite3 gem 1.x. This makes sure we use the right version for each Solidus version.

@mamhoff mamhoff force-pushed the sqlite-troubles branch 2 times, most recently from 21741ea to 35674d4 Compare January 14, 2025 14:09
@mamhoff mamhoff force-pushed the sqlite-troubles branch 5 times, most recently from 2baa04e to 078f203 Compare February 5, 2025 10:26
Older versions of Rails, and thus older versions of Solidus, are
incompatible with the `sqlite3` gem 1.x. This makes sure we use the
right version for each Rails version.
We're expecting the install generator of this gem to change things in
the starter frontend, but the generated Dummy app runs on the legacy
frontend. This fails, migrations don't run, and all tests fail.

This is not the cleanest solution: Ideally we'd have an install
generator for dummy apps that works with the starter frontend template,
but we're not there.
People might have other authentication solutions, and we can simply not
load solidus_auth_devise in specs.
@mamhoff mamhoff force-pushed the sqlite-troubles branch 2 times, most recently from aa881ac to 2cbc1a9 Compare February 12, 2025 08:28
Comment on lines +21 to +22
rails_version = Gem::Requirement.new(rails_requirement_string).requirements[0][1]
sqlite_version = rails_version < Gem::Version.new(7.2) ? "~> 1.4" : "~> 2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this to?

Suggested change
rails_version = Gem::Requirement.new(rails_requirement_string).requirements[0][1]
sqlite_version = rails_version < Gem::Version.new(7.2) ? "~> 1.4" : "~> 2.0"
rails_version = Gem::Version.new(rails_requirement_string)
sqlite_version = rails_version < Gem::Version.new(7.2) ? "~> 1.4" : "~> 2.0"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because the circleci image specifies the rails version as ~> 7.0...

@tvdeyen
Copy link
Member

tvdeyen commented Feb 13, 2025

superseded by #321

@tvdeyen tvdeyen closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants