Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ffaker #15

Closed
wants to merge 1 commit into from
Closed

Remove ffaker #15

wants to merge 1 commit into from

Conversation

jontarg
Copy link

@jontarg jontarg commented Nov 29, 2018

Following solidusio/solidus#2339

When working with extensions, it's required to add ffaker to the Gemfile even when is no longer used.

@kennyadsl
Copy link
Member

ffaker dependency is not needed anymore on Solidus 2.7 but older versions could still need that gem and I think the extensions matrix could break if we merge this now.

Can you please try to run specs on any extension with SOLIDUS_BRANCH=v2.6 (using this branch of solidus_support) and see what happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants