Fix GitHub Pages build #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a custom GitHub Action for Jekyll build to be used instead of the zero-config classic Pages build. This gives us more control over the build stack/dependencies. The Pages source needs to be configured in repository settings: Settings > Pages > Source: GitHub Actions. Fixes solita#519
Updates bundler dependencies (`Gemfile.lock`) using `bundle lock --update`. Bundler version is specified in `Dockerfile` (for local testing) and in `jekyll.yml` (for CI build).
jarnovayrynen
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom GitHub Action for Jekyll build to be used instead of the zero-config classic Pages build (which is now broken as it uses
actions/jekyll-build-pages@v1.0.11where 1.0.10 and 1.0.11 have problems). This gives us more control over the build stack/dependencies. This action/workflow is based on the generic jekyll.yml workflow template which (I think) is more flexible compared to the jekyll-gh-pages.yml template (which uses actions/jekyll-build-pages, another Ruby based Docker image to do the actual building with some additional dependencies and configuration).After merge: The Pages source needs to be configured in repository settings:
Settings>Pages>Source:GitHub Actions.This change has been tested to work in my fork with the blog build deployed to https://haprog.github.io/solita.github.com/ (along with extra baseurl fixes that are not included in this PR as they're not necessary here)
Also updates bundler dependencies (
Gemfile.lock) usingbundle lock --update. Bundler version is specified inDockerfile(for local testing) and injekyll.yml(for CI build).Related docs:
Fixes #519