suppport on demand

solo-io · Dec 24, 2024 · 0a93dcb · 0a93dcb
1 parent 256884f
commit 0a93dcb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/.github/workflows/nightly-tests.yaml b/.github/workflows/nightly-tests.yaml
@@ -418,7 +418,9 @@ jobs:
 
   performance_tests_on_demand:
     name: on demand performance tests
-    if: ${{ env.ENABLE_PERFORMANCE_TESTS == 'true' && (github.event_name == 'workflow_dispatch' && inputs.run-performance && inputs.branch == 'workflow_initiating_branch') }}
+    # This job does not respect the environment value of ENABLE_PERFORMANCE_TESTS
+    # This way, if a developer wanted to run the job on-demand, they could
+    if: ${{ github.event_name == 'workflow_dispatch' && inputs.run-performance && inputs.branch == 'workflow_initiating_branch' }}
     runs-on: ubuntu-22.04
     timeout-minutes: 60
     steps: