Add run attempt to artefact name

solo-io · Dec 19, 2024 · 74d2481 · 74d2481
1 parent 40982f1
commit 74d2481
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/composite-actions/performance-tests/action.yaml b/.github/workflows/composite-actions/performance-tests/action.yaml
@@ -15,6 +15,6 @@ runs:
   - uses: actions/upload-artifact@v4
     if: ${{ failure() }}
     with:
-      name: performance-dump
+      name: performance-dump-attempt-${{ github.run_attempt }}
       path: "_output/performance-artifacts"
       if-no-files-found: warn
diff --git a/.github/workflows/composite-actions/regression-tests/action.yaml b/.github/workflows/composite-actions/regression-tests/action.yaml
@@ -39,6 +39,6 @@ runs:
   - uses: actions/upload-artifact@v4
     if: ${{ failure() }}
     with:
-      name: ${{matrix.kube-e2e-test-type}}@k8s${{matrix.kube-version.kubectl}}-kube-dump
+      name: ${{matrix.kube-e2e-test-type}}-attempt-${{ github.run_attempt }}@k8s${{matrix.kube-version.kubectl}}-kube-dump
       path: "_output/kube2e-artifacts"
       if-no-files-found: warn
diff --git a/changelog/v1.15.35/run-attempt-115.yaml b/changelog/v1.15.35/run-attempt-115.yaml
@@ -0,0 +1,7 @@
+changelog:
+- type: NON_USER_FACING
+  description: >-
+    Add run attempt to test result upload to ensure a unique name per artefact
+
+    skipCI-kube-tests:true
+    skipCI-docs-build:true