Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken GA CI build #10453

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix broken GA CI build #10453

merged 2 commits into from
Dec 6, 2024

Conversation

rpunia1
Copy link

@rpunia1 rpunia1 commented Dec 6, 2024 •
edited
Loading

Follow-up for PR : #10421

Issue:

  • above PR broke GA CI build for re-tagging and pushing images(kubectl, certgen) to GCR, as they are multiarch.
    broken GA build

Fix:

  • build & push images to GCR instead of retagging & pushing them them (build cache is already there so it doesn't take much time in rebuilding for another registry)

Also enabled pushing to GCR besides Quay for Dev build so we can catch errors before merging code and running GA build.

testing

dev build

@rpunia1 rpunia1 self-assigned this Dec 6, 2024
nfuden
nfuden approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but given multi arch this makes sense

sheidkamp
sheidkamp reviewed Dec 6, 2024
View reviewed changes
Copy link

@sheidkamp sheidkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically same as Nathan - untested but aligns with what we discussed yesterday

@soloio-bulldozer soloio-bulldozer bot merged commit a897549 into main Dec 6, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the rav/multiarch-fixes branch December 6, 2024 12:58
rpunia1 added a commit that referenced this pull request Dec 6, 2024
@rpunia1
fix broken GA CI build (#10453)
9d704d7
@rpunia1 rpunia1 mentioned this pull request Dec 6, 2024
Merged
sheidkamp pushed a commit that referenced this pull request Dec 6, 2024
@rpunia1 @sheidkamp
fix broken GA CI build (#10453)
f6f562e
@sheidkamp sheidkamp mentioned this pull request Dec 6, 2024
Closed
soloio-bulldozer bot pushed a commit that referenced this pull request Dec 6, 2024
@rpunia1 @nfuden
[1.18] fix broken GA CI build (#10453) (#10454)
286f123 
Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
kevin-shelaga pushed a commit that referenced this pull request Dec 13, 2024
@rpunia1 @kevin-shelaga
fix broken GA CI build (#10453)
8a7d4a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheidkamp sheidkamp sheidkamp approved these changes

@nfuden nfuden nfuden approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

@rpunia1 rpunia1

Labels
keep pr updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpunia1 @sheidkamp @nfuden