-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps Gateway API Dependencies #10457
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit ce8ee07): https://gloo-edge--pr10457-issue-10456-chcdz7ob.web.app (expires Tue, 17 Dec 2024 16:07:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@@ -4,4 +4,4 @@ kind_version='v0.24.0' | |||
helm_version='v3.14.4' | |||
argocd_version='v2.8.4' | |||
istio_version='1.22.0' | |||
k8sgateway_api_version='v1.2.0' | |||
k8sgateway_api_version='v1.2.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we have the equivalent for https://github.com/solo-io/gloo/blob/main/.github/workflows/.env/pr-tests/versions.env?
I know this is a bit outside the scope of this PR (and I'm happy if we do it in a separate PR), but given that we identified this drift, could we add the k8sgateway_api_version to the pr-test env file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-heilbron ^ is being resolved by #10390.
changelog: | ||
- type: FIX | ||
issueLink: https://github.com/solo-io/gloo/issues/10456 | ||
resolvesIssue: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? We need to update the solo-projects dep to run this in CI as well before it is considered complete imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ issue is for gloo. IMHO solo-projects should have a separate issue to bump the gloo dep. I created https://github.com/solo-io/solo-projects/issues/7404 for this purpose.
Note that this task will be automated in the future with |
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
Bumps Gateway API dependencies from v1.2.0 to v1.2.1.
BOT NOTES:
resolves #10456