Allow escaped json to survive rendering #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't run push CI
kdorosh
reviewed
Jul 21, 2023
Comment on lines
+60
to
+67
| // get the value as a dump() to properly escape values | ||
| val = value->dump(); | ||
|
|
||
| // strip the leading and trailing " characters that are added by dump() | ||
| // if C++20 is adopted, val.starts_with and val.ends_with would clean this up a bit | ||
| val = val.substr(0,1) == "\"" && val.substr(val.length()-1,1) == "\"" | ||
| ? val.substr(1, val.length()-2) | ||
| : val; |
There was a problem hiding this comment.
one last thing i just noticed.. if this is already known to be a string, can we just get the string value instead of dumping as json?
i.e.
// store a string in a JSON value
json j_string = "this is a string";
// retrieve the string value
auto cpp_string = j_string.template get<std::string>();
There was a problem hiding this comment.
per readme in https://github.com/nlohmann/json
There was a problem hiding this comment.
The .get<std::string>() does not escape characters, whereas .dump() does.
kdorosh
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to .dump() strings instead of .getstd::string().
this is useful in cases where the output of the rendered template is expected to be valid JSON. For example:
Input:
{ "foo": "\"bar\"" }Template:
Output (without allowing escaped strings):
{ "FOO": ""bar"" }Output (allowing escaped strings):
{ "FOO": "\"bar\"" }