-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split docker makefile in toolchain build and firmware build #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"git describe" is used to get the version of the firmware from GIT tags ans it is used for build artifacts' names We would prefer not to have this depency inside Docker
…are (especially Docker)
Thank you! |
@all-contributors please add @ccinelli for infrastructure, tests |
I've put up a pull request to add @ccinelli! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include:
Dockerfile
installs everything except thesolo-python
. At the same time checkout again the code inside the container. So in order to build the firmware we have to push the code toorigin
. This PR uses Docker to build a toolchain container that can build the firmware but use the code on the local machine. This is done mapping the main repo inside/solo
in the container.make docker-build-toolchain
builds the toolchain andmake docker-build-all
builds all the different type of the firmware.VERSION_FULL
in one place and remove the dependency on GIT in the docker. In multiple makefilesgit describe
is used to decide theversion
of the firmware. It is better to do this only once in the mainMakefile
and pass the version (VERSION_FULL
) to the other makefiles.solo-python
python package8-2019-q3
.sha2
files to.gitignore
makefile update
to download the latest firmware frommaster
You can test it by running
make docker-build-toolchain
andmake docker-build-all