Move certs and lock to data #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2019
Merged
szszszsz
reviewed
Nov 7, 2019
| @@ -745,16 +741,21 @@ uint8_t ctaphid_custom_command(int len, CTAP_RESPONSE * ctap_resp, CTAPHID_WRITE | |||
|
|
|||
| case CTAPHID_GETVERSION: | |||
| printf1(TAG_HID,"CTAPHID_GETVERSION\n"); | |||
| wb->bcnt = 3; | |||
| wb->bcnt = 4; | |||
| ctap_buffer[0] = SOLO_VERSION_MAJ; | |||
| ctap_buffer[1] = SOLO_VERSION_MIN; | |||
| ctap_buffer[2] = SOLO_VERSION_PATCH; | |||
There was a problem hiding this comment.
Correct me if I am wrong, but I believe any site can call this command. Is it button-guarded? If not, then it would be nice to add such user confirmation to avoid providing additional data for fingerprinting.
There was a problem hiding this comment.
Websites cannot issue HID commands through FIDO API. It is potentially additional info for fingerprinting. It's main use is to silently tell if the device needs a firmware update, so requiring a button press would hamper the UX. I'm for keeping it silent.
There was a problem hiding this comment.
Let's move the further conversation to #339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fully separates the "hacker" and "secure" state differences to not be compiled into the application, and stored as separate data. So builds after this point do not need to be separated into "secure" and "hacker builds. The main motivation for this is to simplify the update procedure.
The bootloader, however, is unchanged. It needs to have two separate builds for checking signatures or not, which is fine since it's not included in the Solo update.
Two main changes to make this work:
To pair with these changes, the "bundle" builds will be configured to store the certificate and lock information, WIP.