Fix nil dereference panic on request timeout (openshift#906)

soltysh · May 31, 2017 · 3e4120e · 3e4120e
1 parent d8c7494
commit 3e4120e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/brokerapi/openservicebroker/open_service_broker_client.go b/pkg/brokerapi/openservicebroker/open_service_broker_client.go
@@ -148,7 +148,11 @@ func (c *openServiceBrokerClient) CreateServiceInstance(ID string, req *brokerap
  )
  if err != nil {
  glog.Errorf("Error sending create service instance request to broker %q at %v: response: %v error: %#v", c.name, serviceInstanceURL, resp, err)
- return nil, resp.StatusCode, errRequest{message: err.Error()}
+ errReq := errRequest{message: err.Error()}
+ if resp == nil {
+ return nil, 0, errReq
+ }
+ return nil, resp.StatusCode, errReq
  }
  defer resp.Body.Close()