Improved govet blacklist #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
soltysh
pushed a commit
that referenced
this pull request
Jun 29, 2017
Automatic merge from submit-queue spec update
soltysh
pushed a commit
that referenced
this pull request
Jul 24, 2017
Addresses the following comments against the first pull request (openshift#14143): openshift#14143 (review) openshift#14143 (review)
soltysh
pushed a commit
that referenced
this pull request
Sep 18, 2017
Building images from RPM takes quite a bit of time, so add service catalog to the local image build list. A prerequisite for this task is to have the service catalog binaries compiled, which is done with #1: 1) cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog/hack/build-go.sh 2) hack/build-local-images service-catalog The first script uses the origin tooling to build in the same way as the RPMs are built. Note that a new "enable_default" key has been added to the image_config and set to False for service catalog so that it is not built unless directly specified (as indicated in #2).
soltysh
pushed a commit
that referenced
this pull request
Feb 12, 2018
Automatic merge from submit-queue. CLI: add support for deployments in oc status @smarterclayton this is a long overdue... current state: ``` $ oc status In project My Project (myproject) on server https://127.0.0.1:8443 svc/ruby-deploy - 172.30.174.234:8080 deployment/ruby-deploy deploys istag/ruby-deploy:latest <- bc/ruby-deploy source builds https://github.com/openshift/ruby-ex.git on istag/ruby-22-centos7:latest build #1 failed 5 hours ago - bbb6701: Merge pull request #18 from durandom/master (Ben Parees <bparees@users.noreply.github.com>) deployment #2 running for 4 hours - 0/1 pods (warning: 53 restarts) deployment #1 deployed 5 hours ago ``` TODO: - [x] Add rollouts similar to deployment configs - [x] Fix unit tests / Add unit tests - [x] Deal with HPA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com