Use same %libdir% directory for avx2 builds, then move libs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the lookup of libraries first searches for haswell libs. However, when we build the libs with %libdir% /usr/lib64/haswell directory, it will hardcode the library path for non LD_LIBRARY lookups in the library itself. For example, glibc breaks when shipping select haswell libraries (there's no need to duplicate most of them), as /usr/lib64/haswell/locale/locale-archive becomes hardcoded path which does not exist. Same applies to %libdir%/gconv/gconv-modules. This patch ensures that libraries are built without haswell paths relying only on LD_LIBRARY lookups to select the faster avx2 library versions where they exist. The sole drawback would be packages making full path symlinks would be broken. This should be very rare (libnss and pulseaudio only on my system) which are from symlinks we create in the build, so easily fixable. Signed-off-by: Peter O'Connor <peter@solus-project.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the lookup of libraries first searches for haswell libs. However,
when we build the libs with %libdir% /usr/lib64/haswell directory, it will
hardcode the library path for non LD_LIBRARY lookups in the library itself.
For example, glibc breaks when shipping select haswell libraries (there's no
need to duplicate most of them), as /usr/lib64/haswell/locale/locale-archive
becomes hardcoded path which does not exist.
Same applies to %libdir%/gconv/gconv-modules.
This patch ensures that libraries are built without haswell paths relying only
on LD_LIBRARY lookups to select the faster avx2 library versions where they
exist.
The sole drawback would be packages making full path symlinks would be broken.
This should be very rare (libnss and pulseaudio only on my system) which are
from symlinks we create in the build, so easily fixable.
Signed-off-by: Peter O'Connor peter@solus-project.com