TASK SIO-3711 add hostname template #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneumyvakin
reviewed
Oct 25, 2021
| @@ -4,4 +4,8 @@ | |||
|
|
|||
| return [ | |||
| 'delete_solus_user' => false, | |||
| 'additional_domain' => [ | |||
There was a problem hiding this comment.
@redikultsevsilver Does this parameter's name is clear?
There was a problem hiding this comment.
@acidmk Please cover this parameter in README.md
There was a problem hiding this comment.
I think it's better to rename this paramenter to e.g. 'hostname_template'.
There was a problem hiding this comment.
changed to default_domain
acidmk
force-pushed
the
task-mkorsakov-add-hostname-template-SIO-3711
branch
from
b40508b to
acd2207
Compare
acidmk
force-pushed
the
task-mkorsakov-add-hostname-template-SIO-3711
branch
from
6e11925 to
f6eefc2
Compare
oneumyvakin
approved these changes
Oct 25, 2021
redikultsevsilver
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.