You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running on the runner instead of in a container (see also #50 (comment), #53) drastically changes what a "release" is for this project, as well as what tests and automations are required.
Expected Behavior
Meaningful tests run for any changes pushed to this repository; Where appropriate these serve as required status checks in pull requests.
The most recent numbered release can be specified in workflows by various labels. For example: @2.2.0, @2.2, and @2 are synonymous when v2.2.0 is the most recent release.
The linter and other frequently-run tests are fast.
Actual Behavior
Currently (04 May 2021) the functions of this action are not tested automatically, the release workflow is wrong, and the linter is slow af.
Possible Fix
Automate integration and validation testing; Implement as required status checks in pull requests.
Automate release tagging.
Find a faster way to run super-linter, or run individual linters on the runner.
Update Makefile to run those ☝️ locally.
Checklist
Lint faster: Are shellcheck and yamllint all we need?
Description
Running on the runner instead of in a container (see also #50 (comment), #53) drastically changes what a "release" is for this project, as well as what tests and automations are required.
Expected Behavior
Meaningful tests run for any changes pushed to this repository; Where appropriate these serve as required status checks in pull requests.
The most recent numbered release can be specified in workflows by various labels. For example:
@2.2.0
,and@2.2
,@2
are synonymous whenv2.2.0
is the most recent release.The linter and other frequently-run tests are fast.
Actual Behavior
Currently (04 May 2021) the functions of this action are not tested automatically, the release workflow is wrong, and the linter is slow af.
Possible Fix
Automate integration and validation testing; Implement as required status checks in pull requests.
Automate release tagging.
Find a faster way to run super-linter, or run individual linters on the runner.
Update Makefile to run those ☝️ locally.
Checklist
shellcheck
andyamllint
all we need?octodns-sync
can be tested without creds and a DNS provider?The text was updated successfully, but these errors were encountered: