Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] hr_timesheet_activity_begin_end_readonly_duration #13

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

ChristianSantamaria
Copy link
Contributor

Change the readonly attribute of field unit_amount to true, to force the Begin Hour and End Hour to be added

Copy link
Collaborator

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review, see comments

@ChristianSantamaria ChristianSantamaria force-pushed the 14.0-add-hr_timesheet_readonly_duration branch from 14924f8 to 2b5ee8f Compare March 15, 2023 13:37
@ChristianSantamaria
Copy link
Contributor Author

Done 👍

@dalonsod
Copy link
Collaborator

OK, I'll test it ASAP!

…ary access to timesheet time fields in form view
@dalonsod
Copy link
Collaborator

Locally tested, 👍

There's only a minor problem in form view edition (you can reach it using kanban view): hr_timesheet_activity_begin_end doesn't provide time_start and time_stop fields here. Then, we're unable to set timesheet hours.

So, I've temporary added them (this sould be a later contribution to OCA IMO).

@ChristianSantamaria could you install it in ArvTest environment?

@ChristianSantamaria
Copy link
Contributor Author

Instaled and tested in test enviroment, LGTM 👍

@dalonsod
Copy link
Collaborator

Great!
I think the two separate commits should be kept in this situation, so no squash needed. You can follow the OCA proposed patch here: OCA/timesheet#577

@dalonsod dalonsod merged commit 9fc3fea into 14.0 Mar 16, 2023
@dalonsod dalonsod deleted the 14.0-add-hr_timesheet_readonly_duration branch March 16, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants