-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
So Many Typo's #229
Merged
Merged
So Many Typo's #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolled up 'action-runner'.
Rolled up 'actions-runner' and 'podman' versions.
…n-runnerdeployment.yaml
Update README.md
THANK YOU!! |
Sorry I failed in proof reading 🧐
*Shaker Gilbert*
Senior Solutions Engineer
…On Wed, Jan 17, 2024 at 11:52 AM Natalie Somersall ***@***.***> wrote:
THANK YOU!!
—
Reply to this email directly, view it on GitHub
<#229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4JVCKSCT5WFWYFKILS7ZTYO76T5AVCNFSM6AAAAABB63TKLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGIYDSNRZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
openshift/README.md
file that improve the clarity of the instructions and correct a few errors. The most significant changes include updating the software version requirement, reordering the steps for deploying the solution, correcting variable names, and improving the instructions for setting up the GitHub App.Here are the key changes:
Improvements in clarity and error correction:
GITHUB_TOKEN
toGITHUB_PAT
.org1-github-app
to${SECRET_NAME}
and the namespace fromactions-runner-system
to${NAMESPACE}
. [1] [2]