Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So Many Typo's #229

Merged
merged 20 commits into from
Jan 17, 2024
Merged

So Many Typo's #229

merged 20 commits into from
Jan 17, 2024

Conversation

shakerg
Copy link
Contributor

@shakerg shakerg commented Jan 17, 2024

This pull request includes changes to the openshift/README.md file that improve the clarity of the instructions and correct a few errors. The most significant changes include updating the software version requirement, reordering the steps for deploying the solution, correcting variable names, and improving the instructions for setting up the GitHub App.

Here are the key changes:

Improvements in clarity and error correction:

  • Updated the required software version from "0.26.0+" to ">0.26.0" and fixed a typo in the description of the benefits of using a single ARC controller-manager across multiple organizations.
  • Reordered the steps for deploying the solution for a GitHub Enterprise Server (GHES) environment and corrected the variable name in the command for setting the controller-manager secret from GITHUB_TOKEN to GITHUB_PAT.
  • Corrected the instructions for setting up the GitHub App, including changing the secret name from org1-github-app to ${SECRET_NAME} and the namespace from actions-runner-system to ${NAMESPACE}. [1] [2]

@some-natalie some-natalie merged commit 900f692 into some-natalie:main Jan 17, 2024
2 of 3 checks passed
@some-natalie
Copy link
Owner

THANK YOU!!

@shakerg
Copy link
Contributor Author

shakerg commented Jan 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants