Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the parse.js for faster parsing of data. #211

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

updated the parse.js for faster parsing of data. #211

wants to merge 3 commits into from

Conversation

manik96m
Copy link
Contributor

No description provided.

@manik96m
updated the parse.js for faster parsing of data.
c42b594 
added a loading flag for the graph when data is being updated.
@vercel
Copy link

vercel bot commented Apr 12, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/p0hj8lcnk
✅ Preview: https://covid19india-n-git-fork-manik96m-performancefix-parsingn-cfd6c5.someshkar.now.sh

@manik96m
Copy link
Contributor Author

manik96m commented Apr 12, 2020 •
edited
Loading

This PR increases the performance of the website with less time in the parsing of data.
Please verify the changes.
I have created an issue related to this as well.

@manik96m manik96m mentioned this pull request Apr 12, 2020
Open
ishantmehtaharness
ishantmehtaharness approved these changes Apr 12, 2020
View reviewed changes
Copy link

@ishantmehtaharness ishantmehtaharness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

@someshkar
Copy link
Owner

@manik96m this doesn't seem to provide any discernible performance benefit as such?

Moreover, can you resolve the merge conflicts before going forward?

@manik96m
Merge branch 'master' into performancefix/parsingNetworkData
0a0fba2 
# Conflicts:
#	components/NetworkMap/index.js
#	components/Redux/actionTypes.js
#	components/Redux/actions.js
#	components/Redux/reducers.js
#	components/SidePanel/header.js
@manik96m
Copy link
Contributor Author

manik96m commented Apr 13, 2020 •
edited
Loading

@someshkar -
I have resolved the merge conflicts.
Try changing the date from the date picker to see the load time difference in the current website and the one after the deployment. I feel this will improve the data changes to reflect faster than before.
Also, have you checked this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishantmehtaharness ishantmehtaharness ishantmehtaharness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manik96m @someshkar @ishantmehtaharness