Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value support and Config.getHeaderNames() method #27

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

ciarant
Copy link
Contributor

@ciarant ciarant commented Oct 31, 2021

Add default value support (#14)

Add Config.getHeaderNames() (#18). I didn't expose the other protected attributes of Config - maybe we could handle this as a separate issue @daniel-bray-sonalake?

Removed duplicate IOException declarations from ExamplesTest.

Add Config.getHeaderNames() (#18)
Removed duplicate exception declarations from ExamplesTest
Copy link
Collaborator

@daniel-bray-sonalake daniel-bray-sonalake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, implements the feature and is tested (and the tests pass ;) )

@daniel-bray-sonalake daniel-bray-sonalake merged commit 1c517be into sonalake:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants