-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phpstan errors for tests #6961
Fix phpstan errors for tests #6961
Conversation
134cb17
to
928c44a
Compare
53bf0c5
to
4e769b1
Compare
@phansys I get an error with
Static access to instance property Sonata\AdminBundle\Tests\Controller\CRUDControllerTest::$httpMethodParameterOverride. I don't really understand this code ; can you confirm it's valid ? |
4e769b1
to
b96a32b
Compare
I need psalm/psalm-plugin-symfony#160 |
4ff8f99
to
362f48a
Compare
362f48a
to
5a2fe75
Compare
I think yes. This is an example about how it works: https://3v4l.org/LcsM6. |
Ok, I created an issue: phpstan/phpstan#4734 |
The lint issue is related to PHP-CS-Fixer/PHP-CS-Fixer#5505 |
Now I just need sonata-project/dev-kit#1473 |
1e9aada
to
45be982
Compare
45be982
to
dc61421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! It would be good to have a changelog for the things changed on the src folder
I think it's only phpdoc |
.