Drop dbal 2, add attributes, increase psalm version #1714

jordisala1991 · 2023-02-26T18:55:12Z

Subject

I am targeting this branch, because this is BC.

### Removed
- Drop support for `doctrine/dbal` ^2.0.
- Drop support for `doctrine/persistence` ^2.0.

src/Model/ModelManager.php

tests/App/DataFixtures/BookFixtures.php

composer.json

jordisala1991 added 3 commits February 26, 2023 19:54

Drop dbal 2, add attributes, increase psalm version

ed3087e

Fix tests

770b891

Rewrite some tests

3f58455

jordisala1991 added the minor label Feb 27, 2023

jordisala1991 added 3 commits February 27, 2023 09:08

Fix cs

547355a

avoid using abstract argument

15a3a89

improve test

763217e

jordisala1991 commented Feb 27, 2023

View reviewed changes

src/Model/ModelManager.php Outdated Show resolved Hide resolved

jordisala1991 marked this pull request as ready for review February 27, 2023 08:21

jordisala1991 requested review from VincentLanglet and a team February 27, 2023 08:21

VincentLanglet requested changes Feb 27, 2023

View reviewed changes

tests/App/DataFixtures/BookFixtures.php Show resolved Hide resolved

dmaicher reviewed Feb 27, 2023

View reviewed changes

composer.json Outdated Show resolved Hide resolved

avoid change on src

1ad8191

jordisala1991 requested review from VincentLanglet, phansys and dmaicher February 28, 2023 07:53

dmaicher approved these changes Feb 28, 2023

View reviewed changes

phansys approved these changes Feb 28, 2023

View reviewed changes

VincentLanglet approved these changes Feb 28, 2023

View reviewed changes

VincentLanglet merged commit 7f42bfd into sonata-project:4.x Feb 28, 2023