Remove doctrine managers #494
Conversation
|
You are probably right, this is supposed to save the media into the database. But now this is handled by doctrine's event. |
|
Please rebase @EmmanuelVella |
EmmanuelVella
force-pushed
the
managers
branch
3 times, most recently
from
b446c1d to
779946d
Compare
|
@core23 Rebase done (but I can't test as I'm not using this bundles anymore). |
|
Thanks @EmmanuelVella Maybe we can leave both files and add a deprecation notice instead? |
EmmanuelVella
force-pushed
the
managers
branch
from
779946d to
faa5e09
Compare
|
@core23 That a good idea. I have updated my PR. |
| @@ -19,6 +19,8 @@ | |||
| /** | |||
| * this method overwrite the default AdminModelManager to call | |||
| * the custom methods from the dedicated media manager. | |||
| * | |||
| * @deprecated | |||
There was a problem hiding this comment.
Can you please leave a comment here?
@deprecated since XXX (to be removed in 3.0)
EmmanuelVella
force-pushed
the
managers
branch
from
faa5e09 to
c3d484a
Compare
|
Done ! |
EmmanuelVella
force-pushed
the
managers
branch
from
c3d484a to
0790af6
Compare
|
Users need to know since when they are deprecated and when they will be removed. @EmmanuelVella |
|
ping @EmmanuelVella |
|
I have updated the deprecated message. |
| @@ -19,6 +19,8 @@ | |||
| /** | |||
| * this method overwrite the default AdminModelManager to call | |||
| * the custom methods from the dedicated media manager. | |||
| * | |||
| * @deprecated This class is deprecated since version 2.4 and will be removed in 3.0. | |||
|
@EmmanuelVella According to sonata-project/SonataAdminBundle#3731, sonata media bundle won't be 2.4 but 3.0. After that, if those manager are really not used, I think we could accept this BC break for 3.0. I'll ping you when the 3.x will be ready so you will be able to rework this PR. 👍 |
|
Ho ok I didn't know there won't be a 2.4 version. Waiting for your ping then ! |
|
Thank you @EmmanuelVella, I cherry-picked your commit with deletion instead of deprecation. |
|
ok 👍 |
It seems there is no reason to keep these managers ?