Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pedantic label #128

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

soullivaneuh
Copy link
Member

@soullivaneuh soullivaneuh commented Jun 1, 2016

This label will be used on PRs concerning change not related to any patch, minor or major tag.

This can concerns PRs about typos, coding style or whatever that does not affect the code working itself.

Please note that PRs about documentation already have the docs label. Do not use pedantic on them.

PRs with docs or pedantic labels should not have a changelog.

If anyone have a better suggestion, feel free to comment! 👍

cc @sonata-project/contributors

@soullivaneuh soullivaneuh self-assigned this Jun 1, 2016
@OskarStark
Copy link
Member

sound good to me

offtpoic: can we rename docs to Documentation ?

@soullivaneuh
Copy link
Member Author

offtpoic: can we rename docs to Documentation ?

You could open an issue to vote on that.

Currently you technically can't because actual dev-kit would add Documentation and remove docs one. This would remove the label from all attached PRs...

But I can work on a solution if needed. 👍

@soullivaneuh soullivaneuh merged commit ae18f3e into sonata-project:master Jun 1, 2016
@soullivaneuh soullivaneuh deleted the label-pedantic branch June 1, 2016 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants