Remove development files from Composer package #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
previously approved these changes
Aug 19, 2020
core23
reviewed
Aug 19, 2020
localheinz
reviewed
Sep 23, 2020
OskarStark
approved these changes
Sep 23, 2020
VincentLanglet
approved these changes
Sep 23, 2020
|
Thank you @jorrit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #130 (comment) it was suggested to remove Makefile and phpunit.xml.dist from the Composer package. Although this seems everyone agreed, these filenames were not added to .gitattributes.
In this PR this is fixed and I also exclude the phpstan files that have been added to some Sonata projects since then.