Add KnpSnappyWriter #86
Conversation
greg0ire
force-pushed
the
chalasr-chalasr-master
branch
from
7319fe2 to
93df253
Compare
|
|
| $this->wkhtmltopdf = __DIR__.'/../../../../../vendor/h4cc/wkhtmltopdf-amd64/bin/wkhtmltopdf-amd64'; | ||
|
|
||
| if (!is_executable($this->wkhtmltopdf)) { | ||
| $this->markTestSkipped('The wkhtmltopdf binary is not available'); |
There was a problem hiding this comment.
Should not be a failed? AFAIK, the binary is downloaded from composer so it should be always available for tests.
There was a problem hiding this comment.
Hmmm… probably a legacy from before doing this with Composer ? @chalasr , can you help ?
There was a problem hiding this comment.
In fact, h4cc binaries don't work on osx at all (this is why it was previously set to /usr/local/bin), and is separated in two 32/64 packages. It was a kind of security for don't break them all.
|
Not sure about |
There is not call to |
BTW, I would like to refactor some test later,it would be great to have a plan. |
|
Discussion is here : sonata-project/dev-kit#89 |
|
I don't think this should be part of the project. Rendering PDF is more about reporting that exporting raw data (the idea of this lib). The PDF output will never match client's requirements. This code should be included on a dedicated reporting bundle, with specific output handler: princexml, wkhtml, etc ... |
|
Hmm so off-topic… I did not see that because I don't know the library that well… closing then. |
|
Yeah just saw that indeed. We should create sonataReportingBundle ;) |
|
At first a Reporter lib could be sufficient and, in a next time, integrate it in the admin-bundle through a Reporter class like done for this lib. |
Changelog
Subject
This PR is my take on #76 , thanks @chalasr for what you already did
To do
- [ ] consider relying on knp/snappy-bundle to inject the dependencythis is not a symfony bundle so we can't