-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate sonata_urlsafeid in favor of SonataAdminBundle #225
Conversation
a6802b5
to
ee10047
Compare
src/Extension/TemplateExtension.php
Outdated
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 and will be removed in version 2.0' | ||
.' in favor of the "sonata_urlsafeid" method of the SonataAdminBundle.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 and will be removed in version 2.0' | |
.' in favor of the "sonata_urlsafeid" method of the SonataAdminBundle.' | |
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 in favor of the "sonata_urlsafeid"' | |
.' Twig filter defined by SonataAdminBundle and will be removed in version 2.0.' |
src/Extension/TemplateExtension.php
Outdated
@trigger_error(sprintf( | ||
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 and will be removed in version 2.0' | ||
.' in favor of the "sonata_urlsafeid" method of the SonataAdminBundle.' | ||
.' You might solve this deprecation by declaring this bundle before the SonataAdminBundle one.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.' You might solve this deprecation by declaring this bundle before the SonataAdminBundle one.', | |
.' You can solve this deprecation by enabling this bundle before SonataAdminBundle.', |
ee10047
to
3b504e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TemplateExtension there is also this:
twig-extensions/src/Extension/TemplateExtension.php
Lines 50 to 56 in 283c0a3
public function getTokenParsers(): array | |
{ | |
return [ | |
new TemplateBoxTokenParser($this->debug), | |
]; | |
} | |
is it ok to deprecate it?
3b504e2
to
36ae310
Compare
I don't know what it's used for, so I changed the deprecation to only deprecating the filter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently is for sonata_template_box
twig tag
https://github.com/search?q=org%3Asonata-project+sonata_template_box&type=code
Thanks @VincentLanglet ! |
Subject
I am targeting this branch, because BC.
Closes sonata-project/SonataAdminBundle#7068.
Changelog