Fix StatusClassRenderer implementation

[wbloszyk]

Subject

After add type hints in Sonata\Twig\Extension\StatusRuntime get status class from string (flash massage type) is not possible and TypeError is throwed. This PR fix StatusClassRendererInterface implementation in FlashManager and remove some type hints which make BC-break.

I am targeting this branch, because this change respect BC.

Closes #89.

Changelog

### Fixed
- Fix `Sonata\Twig\Status\StatusClassRendererInterface` implementation in `Sonata\Twig\FlashMessage\FlashManager`
- Fix `Sonata\Twig\Extension\StatusRuntime` to working with `Sonata\Twig\FlashMessage\FlashManager` again, after add type hints

[wbloszyk]

@phansys @core23 @VincentLanglet
I close #90 becouse it is hard to understand. I will split it to more atomic PR to better understand what is changing:

• fix BC-break after add type hints - this PR
• improve FlashManager - another RP

This PR is RTM. Can you check it?

[wbloszyk]

@core23 @VincentLanglet @phansys @greg0ire Can you check it?

[phansys]

Thank you @wbloszyk!

[benrcole]

I cant be certain because I don't fully understand how the engine works but I think there's a problem with StatusRuntime::statusClassForFlashManager that's included within this change.

With this change my templates now render the flashes but the relevant css class is misssing for each flash type. I think it's down to the below code fragment. My suspicion is that the wrong parameter is being sent to handlesObject below.

 private function statusClassForFlashManager(string $object, ?string $statusType = null, string $default = ''): string
    {
        if ($flashManager = $this->getFlashManagerFromStatusServices()) {
            if ($flashManager->handlesObject($flashManager, $statusType)) {
                if (null === $statusType) {
                    $statusType = $object;
                }

Sending $object instead of $statusType as below makes the templates render correctly

    private function statusClassForFlashManager(string $object, ?string $statusType = null, string $default = ''): string
    {
        if ($flashManager = $this->getFlashManagerFromStatusServices()) {
            if ($flashManager->handlesObject($flashManager, $object)) {
                if (null === $statusType) {
                    $statusType = $object;
                }
...

Is this a correct fix or am I missing some config somewhere else?

[wbloszyk]

@benrcole Look at https://github.com/sonata-project/twig-extensions/blob/1.x/docs/reference/status_helper.rst
and https://github.com/sonata-project/ecommerce/blob/3.x/src/Component/Order/OrderStatusRenderer.php
Change in remove src/FlashMessage/FlashManager.php fit it for correct way.

Can you open issue for this with reproduction information?

Im also working on #90 where using StatusClassRenderer and FlashManager will be more obvius.

[benrcole]

I have opened #93 with reproducible steps