removed incorrect handlesObject call #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please write a changelog directed at end users. Keep in mind that they probably do not care what file or class you changed, but what features you provided / what bugs you fixed. Try to answer the question "What benefit do I get from upgrading?" EDIT: fixed it by keeping the "Fixed" section only |
wbloszyk
approved these changes
Jun 28, 2020
greg0ire
approved these changes
Jun 28, 2020
VincentLanglet
approved these changes
Jun 28, 2020
|
Does a unit test should/could be added ? |
|
Tomorrow I will work on it. FlashManager will be rebuild to own/seperate usages. It means test will be rebuild too. Do it here now is not nesesery. |
core23
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Fix for #93 as requested
I am targeting this branch, because the patch is needed here.
Closes #93.
Changelog