fix: linting

.golangci.yml

@@ -1,14 +1,38 @@
-run:
-  linters-settings:
-    govet:
-       enable-all: true
-  linters:
-    enable-all: true
-    disable:
-      - gochecknoglobals
-      - gomnd
-      - gocognit
-      - nestif
-      - nilnil
-      - paralleltest
-      - varnamelen
+linters:
+  enable-all: true
+  disable:
+    - execinquery # deprecated
+    - exportloopref # deprecated
+    - gomnd # deprecated
+    - gochecknoglobals
+    - exhaustruct
+    - mnd
+    - gocognit
+    - nestif
+    - nilnil
+    - paralleltest
+    - varnamelen
+
+linters-settings:
+  govet:
+     enable-all: true
+  perfsprint:
+    err-error: true
+    errorf: true
+    sprintf1: true
+    strconcat: false
+  depguard:
+    rules:
+      main:
+        deny:
+          - pkg: "github.com/instana/testify"
+            desc: not allowed
+          - pkg: "github.com/pkg/errors"
+            desc: Should be replaced by standard lib errors package
+
+output:
+  show-stats: true
+  sort-results: true
+  sort-order:
+    - linter
+    - file

ngfunc/main.go

@@ -39,6 +39,7 @@ func ngCalledFuncs(pass *analysis.Pass, ngFuncs []*types.Func) []*Report {
 	if !ok {
 		panic(fmt.Sprintf("%T is not *buildssa.SSA", pass.ResultOf[buildssa.Analyzer]))
 	}
+
 	for _, sf := range ssa.SrcFuncs {
 		for _, b := range sf.Blocks {
 			for _, instr := range b.Instrs {

ngfunc/types.go

@@ -1,15 +1,15 @@
 package ngfunc
 
 import (
-	"fmt"
+	"errors"
 	"go/types"
 	"strings"
 
 	"github.com/gostaticanalysis/analysisutil"
 	"golang.org/x/tools/go/analysis"
 )
 
-var errNotFound = fmt.Errorf("function not found")
+var errNotFound = errors.New("function not found")
 
 func typeFuncs(pass *analysis.Pass, funcs []string) []*types.Func {
 	fs := make([]*types.Func, 0, len(funcs))

noctx.go

@@ -2,6 +2,7 @@ package noctx
 
 import (
 	"fmt"
+
 	"github.com/sonatard/noctx/ngfunc"
 	"github.com/sonatard/noctx/reqwithoutctx"
 	"golang.org/x/tools/go/analysis"

reqwithoutctx/ssa.go

@@ -5,7 +5,6 @@ import (
 	"go/types"
 
 	"github.com/gostaticanalysis/analysisutil"
-
 	"golang.org/x/tools/go/analysis"
 	"golang.org/x/tools/go/analysis/passes/buildssa"
 	"golang.org/x/tools/go/ssa"