Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix coverage targets and re-enable coverage targets in CI #273

Open
bhamail opened this issue Dec 8, 2023 · 0 comments
Open

[BUG] Fix coverage targets and re-enable coverage targets in CI #273

bhamail opened this issue Dec 8, 2023 · 0 comments
Labels

Comments

@bhamail
Copy link
Contributor

bhamail commented Dec 8, 2023

During gyrations to remove a vulnerable dependency, the required updates broke the nyc coverage targets.
This issue is to remember to restore the coverage targets to their former glory.

See: target coverage - https://github.com/sonatype-nexus-community/auditjs/blob/main/package.json#L26
target generate-coverage-report - https://github.com/sonatype-nexus-community/auditjs/blob/main/package.json#L27

Once nyc coverage is working again, CI coverage can be re-enabled here: https://github.com/sonatype-nexus-community/auditjs/blob/main/.circleci/config.yml#L42C20-L42C20

cc @bhamail / @DarthHater / @allenhsieh / @Slim-Shary

@bhamail bhamail added the bug label Dec 8, 2023
bhamail added a commit that referenced this issue Dec 13, 2023
…e dependency on inflight package

* disable broken coverage target for now. restore coverage targets later - see Issue #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant