Set MSRV, and up to 1.53 due to issues with net library #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-keibler
reviewed
Aug 18, 2021
amy-keibler
approved these changes
Aug 18, 2021
bhamail
approved these changes
Aug 19, 2021
|
@amy-keibler @bhamail I used the suggestion from: https://users.rust-lang.org/t/call-for-testing-unstable-cargo-support-for-rust-version/59386 so we are at least setup based on what looks like is coming |
amy-keibler
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues with the net library prior to 1.53, and it is likely we use it, so this move is mostly a) let's just move up to MSRV of 1.53 to avoid a lengthy look at if we are totally affected.
This pull request makes the following changes:
1.53in CircleCIrust-version = 1.53inCargo.tomlBuild failure fixed now that we can ignore a vulnerability (done in #57 )