Iq trailing slash part 2 electric boogalo #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leading to an invalid report url
…eport url using the URL object
ButterB0wl
changed the title
ButterB0wl
added a commit
that referenced
this pull request
Feb 12, 2021
* Splittttt * Iq trailing slash part 2 electric boogalo (#184) * fix: handled case where trailing slash is in the IQ endpoint setting leading to an invalid report url * put it up top in the constructor * changed string casting in iq component model constructor and joined report url using the URL object Co-authored-by: Artemie Jurgenson <37317224+ButterB0wl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bhamail / @DarthHater