Expose forceBasicAuth to createDockerGroup and createDockerProxy #41
Conversation
|
@joedragons Hello. If possible, please include this PR in the same nexus release as PR #31 (in 3.14 release?) so that the release has a consistent API. |
|
@micw 3.14 is already being cut so I doubt this will make it, but thanks for sending it our way! |
There was a problem hiding this comment.
This looks fine to me (I'll leave approval to someone on the core team), the only thing I can think of is maybe just modifying the original createDockerProxy and createDockerGroup methods and adding @deprecated to them (since it's basically the same signature now).
|
@joedragons could you please look into this which is a follow-up to complete what was started in #31? |
|
I have minimal insight into code but I'll ping the team. |
|
@joedragons Any news about this? Thank you, Michael. |
|
@micw No news from me. As you may see from this or other experiences, we don't do a lot of work out of github. You might have better traction filing a ticket in our JIRA (issues.sonatype.com), explaining what the fix is and referencing this PR. That is a guess on my part, we just have a lot going on and I have minimal clout getting anything moving. |
(was missing in https://github.com/sonatype/nexus-public/pull/31/files)