Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Minor improvements to Spotify allowlist #73

Closed
parendev opened this issue Aug 23, 2023 · 4 comments
Closed

Feature Request: Minor improvements to Spotify allowlist #73

parendev opened this issue Aug 23, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@parendev
Copy link

Thank you so much for adding the feature requested in #67! I've tested it out and it appears to work great.

A couple small tweaks could make it even better, if possible:

When a song that is requested as a channel points reward is not found on the allowlist, the user's channel points are not automatically refunded. The settings contain a response for a user's points being refunded, which suggests this happens for other errors. It would be nice if this happened when failing to find a song in the allowlist too.

It would also be really nice if the response This song was not found in the allowed playlist.({{playlist name}} {{playlist url}}) could be added to the configurable responses in Settings > Twitch > Responses.

I understand you are very busy. Again, I really appreciate you finding the time to get to #67. :)

@Inzaniity
Copy link
Collaborator

Thank you so much for adding the feature requested in #67! I've tested it out and it appears to work great.

A couple small tweaks could make it even better, if possible:

When a song that is requested as a channel points reward is not found on the allowlist, the user's channel points are not automatically refunded. The settings contain a response for a user's points being refunded, which suggests this happens for other errors. It would be nice if this happened when failing to find a song in the allowlist too.

It would also be really nice if the response This song was not found in the allowed playlist.({{playlist name}} {{playlist url}}) could be added to the configurable responses in Settings > Twitch > Responses.

I understand you are very busy. Again, I really appreciate you finding the time to get to #67. :)

Currently, refunds are not activated. This issue arose from problems with the Twitch PubSub service in the third-party library we rely on. Although it seems this has been fixed, I can't test it myself since I'm no longer affiliated. To enable refunds, channel point rewards must be created via Songify, granting the app permission to alter redemptions.

When I have time to resolve the PubSub-related management of rewards and refunds, I'll be sure to incorporate your suggestion.

The release of version 1.5.x was prioritized to address vital bugs, so I didn't take time to fine-tune the PubSub elements. As a result, I concealed all associated features, including the PubSub Icon on the main window and the notice that pubsub is disabled, as well as the skip-reward and the disclaimer regarding currently inactive features in the settings menu because this caused confusio for some users.

I will keep you updated (either by closing this or referencing it in a commit) once this functionality is implemented!

@Inzaniity Inzaniity self-assigned this Aug 23, 2023
@Inzaniity Inzaniity added the enhancement New feature or request label Aug 23, 2023
@parendev
Copy link
Author

Thank you!

Although it seems this has been fixed, I can't test it myself since I'm no longer affiliated.

I am affiliated. If you'd like some help testing things, I'd be willing to try to find a good time I could help. If you'd like to reach out to me about it, my username on discord is parendev.

Inzaniity added a commit that referenced this issue Aug 28, 2023
@Inzaniity
Copy link
Collaborator

Thank you!

Although it seems this has been fixed, I can't test it myself since I'm no longer affiliated.

I am affiliated. If you'd like some help testing things, I'd be willing to try to find a good time I could help. If you'd like to reach out to me about it, my username on discord is parendev.

Hey! I implemented the requested feature on the playlist stuff (custom response, which is editable). I also added you on Discord, so we can have a chat about the pubsub / refund stuff :)

@Inzaniity
Copy link
Collaborator

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants