Merge pull request #3 from sonh/fix/encoding-empty-slice

Fix encoding for empty slice that causes panic
sonh · Dec 5, 2022 · b0f2786 · b0f2786
2 parents ea61bea + 25f9152
commit b0f2786
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/encode_field.go b/encode_field.go
@@ -113,7 +113,7 @@ func (listField *listField) formatFnc(field reflect.Value, result resultFunc) er
 			}
 		}
 		returnStr := str.String()
-		if returnStr[0] == ',' {
+		if len(returnStr) > 0 && returnStr[0] == ',' {
 			returnStr = returnStr[1:]
 		}
 		result(listField.name, returnStr)

diff --git a/encode_test.go b/encode_test.go
@@ -602,6 +602,7 @@ func TestArrayFormat_Comma(t *testing.T) {
 	tm := time.Unix(600, 0).UTC()
 
 	s := struct {
+		EmptyList  []string     `qs:"empty_list,comma"`
 		StringList []string     `qs:"str_list,comma"`
 		Times      []*time.Time `qs:"times,comma"`
 	}{
@@ -614,8 +615,9 @@ func TestArrayFormat_Comma(t *testing.T) {
 		return
 	}
 	expected := url.Values{
-		"str_list": []string{"a,b,c"},
-		"times":    []string{tm.Format(time.RFC3339)},
+		"empty_list": []string{""},
+		"str_list":   []string{"a,b,c"},
+		"times":      []string{tm.Format(time.RFC3339)},
 	}
 	assert.Equal(t, expected, values)
 }