-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DPU scope DPU driven HA #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshmv
force-pushed
the
dpu_scope_ha_3
branch
2 times, most recently
from
July 2, 2024 05:53
e4b9c41
to
a4256a0
Compare
mukeshmv
changed the title
Add support for DPU driven DPU scope HA attributes
Add support for DPU scope DPU driven HA
Jul 2, 2024
r12f
reviewed
Jul 9, 2024
marian-pritsak
approved these changes
Jul 13, 2024
r12f
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some minor comments in the HLD. Will merge once resolved. thanks Mukesh!
r12f
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
mukeshmv
added a commit
to mukeshmv/SAI
that referenced
this pull request
Jul 17, 2024
Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604
mukeshmv
added a commit
to mukeshmv/SAI
that referenced
this pull request
Jul 23, 2024
Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604 Signed-off-by: mukeshmv <mukesh@pensando.io>
mukeshmv
added a commit
to mukeshmv/SAI
that referenced
this pull request
Jul 23, 2024
Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604 Signed-off-by: mukeshmv <mukesh@pensando.io>
mukeshmv
added a commit
to mukeshmv/SAI
that referenced
this pull request
Jul 24, 2024
Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604 Signed-off-by: mukeshmv <mukesh@pensando.io>
mukeshmv
added a commit
to mukeshmv/SAI
that referenced
this pull request
Jul 24, 2024
Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604 Signed-off-by: mukeshmv <mukesh@pensando.io>
prsunny
pushed a commit
to opencomputeproject/SAI
that referenced
this pull request
Aug 6, 2024
Add Dash DPU scope DPU driven HA attributes (#2055) Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604
siqbal1986
pushed a commit
to siqbal1986/SAI
that referenced
this pull request
Sep 30, 2024
Add Dash DPU scope DPU driven HA attributes (opencomputeproject#2055) Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604 Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
erohsik
pushed a commit
to erohsik/SAI
that referenced
this pull request
Nov 7, 2024
Add Dash DPU scope DPU driven HA attributes (opencomputeproject#2055) Brings in SAI API changes from these DASH PRs sonic-net/DASH#599 sonic-net/DASH#604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SAI API support for the DPU scope DPU driven Dash HA mode described in this PR.
sonic-net/SONiC#1710
In this mode, the HA scope / HA state is at the DPU level. Also the DPU vendor SDK owns the HA state machine and drives state transitions on its own by directly communicating with its HA pair underneath the SAI layer. The DPU SDK advertises HA state changes as SAI event notifications.