Skip to content

Commit

Permalink
Add Warmboot/Fastboot limitation
Browse files Browse the repository at this point in the history
  • Loading branch information
ebiken-ntt committed Sep 18, 2023
1 parent 1199962 commit 76cf405
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions doc/fpmsyncd/hld_fpmsyncd-NTT.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
- [CLI/YANG model Enhancements](#cliyang-model-enhancements)
- [Config DB Enhancements](#config-db-enhancements)
- [Warmboot and Fastboot Design Impact](#warmboot-and-fastboot-design-impact)
- [Restrictions/Limitations](#restrictionslimitations)
- [Testing Requirements/Design](#testing-requirementsdesign)
- [Unit Test cases](#unit-test-cases)
- [System Test cases](#system-test-cases)
Expand All @@ -27,14 +26,15 @@
- [Further performance improvements](#further-performance-improvements)
- [Backward compatibility with current NHG creation logic (Fine-grain NHG, Ordered NHG/ECMP)](#backward-compatibility-with-current-nhg-creation-logic-fine-grain-nhg-ordered-nhgecmp)
- [nexthop\_compat\_mode Kernel option](#nexthop_compat_mode-kernel-option)
- [Warmboot/Fastboot support](#warmbootfastboot-support)

### Revision

| Rev | Date | Author | Change Description |
| :---: | :----------: | :------------------------------------------------: | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| 0.1 | Jul 14, 2023 | Kanji Nakano, Kentaro Ebisawa, Hitoshi Irino (NTT) | Initial version |
| 0.2 | Jul 30, 2023 | Kentaro Ebisawa (NTT) | Remove description about VRF which is not nessesary for NHG. Add High Level Architecture diagram. Add note related to libnl, Routing WG. Fix typo and improve explanations. |
| 0.3 | Sep 18, 2023 | Kentaro Ebisawa (NTT) | Update based on discussion at Routing WG on Sep 14th |
| 0.3 | Sep 18, 2023 | Kentaro Ebisawa (NTT) | Update based on discussion at Routing WG on Sep 14th (Scope, Warmboot/Fastboot) |

### Scope

Expand Down Expand Up @@ -265,12 +265,13 @@ TODO: make it able to disable(default)/enable based on CONFIG_DB
Mention whether this feature/enhancement has got any requirements/dependencies/impact w.r.t. warmboot and fastboot. Ensure that existing warmboot/fastboot feature is not affected due to this design and explain the same.
-->

There should be no impact to Warmboot and Fastboot Design Impact.
The change is how fpmsyncd handle message from zebra.
- When the feature is disabled, there should be no impact to Warmboot and Fastboot.
- When the feature is enabled, there will be no warmboot nor fastboot support.

### Restrictions/Limitations
When the feature is enabled, NHG ID will be managed by FRR which will change after FRR related process or BGP container restart.
We need a way to either let FRR preserve the ID or a way to correlate the NHGs, IDs and it's members before and after the restart.

n/a
We will continue discussion on how we could support Warmboot/Fastboot for future enhancements.

### Testing Requirements/Design

Expand Down Expand Up @@ -336,3 +337,8 @@ There is a `sysctl` option `net.ipv4.nexthop_compat_mode nexthop_compat_mode` wh
This option is not changed as part this HLD to avoid unexpected impact to the existing behavior.

One should carefully study the impact of this change before chainging this option.

#### Warmboot/Fastboot support

Currently this feature does not work with Warmboot/Fastboot.
We will continue discussion on how we could support Warmboot/Fastboot for future enhancements.

0 comments on commit 76cf405

Please sign in to comment.