Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs from Azure to sonic-net #1079

Merged
merged 10 commits into from
Sep 12, 2022
Merged

Update URLs from Azure to sonic-net #1079

merged 10 commits into from
Sep 12, 2022

Conversation

maipbui
Copy link
Contributor

@maipbui maipbui commented Sep 7, 2022

Due to migrating many Github repos from Azure org to sonic-net org.

Signed-off-by: maipbui maibui@microsoft.com

Signed-off-by: maipbui <maibui@microsoft.com>
@@ -2552,7 +2552,7 @@ Following are the list of Open source tools used in Management framework
## 12 Appendix B

Following are the list of Open source libraries used in telemetry container.
Always refer to the [Makefile](https://github.com/Azure/sonic-telemetry/blob/master/Makefile) for the sonic-telemetry container for current package list.
Copy link
Contributor

@qiluo-msft qiluo-msft Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure/sonic-telemetry

This repo is migrated in different way:
Azure/sonic-telemetry -> sonic-net/sonic-gnmi

There are 4 occurrences. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Signed-off-by: maipbui <maibui@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com>
The gNMI support requires the gNMI server which is provided as a part of sonic-telemetry container. We would like to rename this container as the sonic-gnmi container as now it can perform configurations as well through the gNMI server.
Will introduce a new container sonic-mgmt-common to host the common code that is used both in the mgmt-framework and sonic-telemetry container. This new repo will compile into static libraries that will be used in the other two repos. This way sonic-telemetry repo can be compiled without the mgmt-framework being present in the code base.
The gNMI support requires the gNMI server which is provided as a part of sonic-gnmi container. We would like to rename this container as the sonic-gnmi container as now it can perform configurations as well through the gNMI server.
Will introduce a new container sonic-mgmt-common to host the common code that is used both in the mgmt-framework and sonic-gnmi container. This new repo will compile into static libraries that will be used in the other two repos. This way sonic-gnmi repo can be compiled without the mgmt-framework being present in the code base.

Copy link
Contributor

@qiluo-msft qiluo-msft Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's focus on fixing URLs in this PR, do not touch plain text. #Closed

Signed-off-by: maipbui <maibui@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com>
qiluo-msft
qiluo-msft previously approved these changes Sep 9, 2022
Signed-off-by: maipbui <maibui@microsoft.com>
@qiluo-msft
Copy link
Contributor

qiluo-msft commented Sep 12, 2022


Refer HLD document and below mentioned PR's for more details.

Thanks! This change make sense. #Closed


Refers to: doc/SONiC_202106_Release_Notes.md:53 in ef251b1. [](commit_id = ef251b1, deletion_comment = False)

@@ -557,5 +557,5 @@ files/build/versions/
## References

- Ref:
- https://github.com/Azure/SONiC/blob/master/doc/sonic-build-system/DPKG%20caching%20framework%20.ppt
- https://github.com/sonic-net/SONiC/blob/master/doc/sonic-build-system/DPKG%20caching%20framework%20.pptx
Copy link
Contributor

@qiluo-msft qiluo-msft Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.pptx

Thanks for the fix! #Closed

qiluo-msft
qiluo-msft previously approved these changes Sep 12, 2022
Signed-off-by: maipbui <maibui@microsoft.com>
@maipbui maipbui merged commit 4d184fb into sonic-net:master Sep 12, 2022
@maipbui maipbui deleted the sonic_net_migration branch September 12, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants