Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGP Loading Optimization HLD #1521

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

BGP Loading Optimization HLD #1521

wants to merge 4 commits into from
+420 −0

Conversation

a114j0y
Copy link

@a114j0y a114j0y commented Nov 22, 2023 •
edited
Loading

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@a114j0y a114j0y force-pushed the master branch 7 times, most recently from 59e7d20 to 3d8434c Compare November 22, 2023 21:55
kcudnik
kcudnik previously approved these changes Dec 17, 2023
View reviewed changes
@zhangyanzhao
Copy link
Collaborator

not reviewed in sonic community yet.

@a114j0y a114j0y force-pushed the master branch 2 times, most recently from ff8ad44 to 34d6862 Compare February 16, 2024 06:41
@a114j0y a114j0y force-pushed the master branch 2 times, most recently from 05e97a0 to 4ecddec Compare February 29, 2024 22:02
@a114j0y a114j0y force-pushed the master branch 2 times, most recently from fc5039a to 127cb07 Compare March 12, 2024 21:46
@a114j0y a114j0y force-pushed the master branch 2 times, most recently from 5cc61ee to b4eeace Compare March 12, 2024 22:47
@a114j0y a114j0y force-pushed the master branch 3 times, most recently from e7fcc7b to 16cb696 Compare June 6, 2024 21:59
@a114j0y a114j0y force-pushed the master branch 9 times, most recently from 3eb70ac to f4a58af Compare July 20, 2024 03:28
@a114j0y a114j0y mentioned this pull request Jul 22, 2024
Open
@a114j0y a114j0y changed the title BGP Loading Enhancement HLD BGP Loading Optimization HLD Jul 22, 2024
This was referenced Jul 22, 2024
Open
Draft
@zhangyanzhao
Copy link
Collaborator

Community review recording https://zoom.us/rec/share/PkNNRipPYi-z2Q0nkK_FCoFWqXk5oQcQYkNvitanIaWkWw98VXYkdE1SYnSAvQTD.tkZEa9zzBzHlex3c

@yxieca
Copy link
Contributor

yxieca commented Jul 23, 2024

Question: is there sufficient test coverage (unit or integration) to make sure that the ring buffer is drained during warm shutdown?

@yxieca
Copy link
Contributor

yxieca commented Jul 23, 2024

Suggestion: can you separate the lambda function enhancement itself in a separate PR and the other performance improvement code in another PR?

@a114j0y
Copy link
Author

a114j0y commented Jul 23, 2024

Suggestion: can you separate the lambda function enhancement itself in a separate PR and the other performance improvement code in another PR?

I have already separated fpmsyncd / orchagent enhancement into two PRs.

The lambda function is the type of ring entries, so kind of bound with the ring buffer PR. Without lambda, it would be a different implementation and much code change. But might help understand the codes…Do you still think we need to do this？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft left review comments

@kcudnik kcudnik kcudnik left review comments

@saiarcot895 saiarcot895 Awaiting requested review from saiarcot895

@prsunny prsunny Awaiting requested review from prsunny

@Pterosaur Pterosaur Awaiting requested review from Pterosaur

@liuh-80 liuh-80 Awaiting requested review from liuh-80

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
SONiC 202411 Release
Status: 📋 In Plan Features
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@a114j0y @zhangyanzhao @yxieca @qiluo-msft @kcudnik @yangfs1999 @nkelapur