HLD for aggregate VOQ counters. #1587
Conversation
|
|
|
@arlakshm @zhangyanzhao for awareness |
vivekverma-arista
changed the title
|
community review recording https://zoom.us/rec/share/l3l_S2iJIdKTdsnAqEGTI-kEYsr5HL5C4EJfSC4Ct9FO5_2Y66QkFE3zhdz8cmgh.Qkk5g7TeFGFEz328 |
|
@vivekverma-arista can you please help to add the code PRs to this HLD by referring to #806 ? Thanks. |
|
@vivekverma-arista can you please help to update the code PR list by referring to #806 ? Thanks. |
|
@lguohan will check with MSFT team for the review. |
|
code PRs are not reviewed yet. Move to backlog |
vivekverma-arista
requested review from
vmittal-msft,
kenneth-arista and
venkatmahalingam
doc/voq/aggregate_voq_counters.md
Outdated
|
|
||
| The following new VOQ counters should be available for each VOQ entry in the DB: | ||
| * `COUNTERS_VOQ : LINECARD | ASIC | EthernetXXX @ LINECARD | ASIC : VOQ_index` | ||
| * `SAI_VOQ_STAT_PACKETS` |
There was a problem hiding this comment.
AFAIK, only the following SAI attributes are supported to read the counters for both egress queue and voq. Only the queue id is different for egress queue and voq.
in orchagent:
static const vector<sai_queue_stat_t> queue_stat_ids =
{
SAI_QUEUE_STAT_PACKETS,
SAI_QUEUE_STAT_BYTES,
SAI_QUEUE_STAT_DROPPED_PACKETS,
SAI_QUEUE_STAT_DROPPED_BYTES,
};
static const vector<sai_queue_stat_t> voq_stat_ids =
{
SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS
};
SAI
https://github.com/opencomputeproject/SAI/blob/be523777da96504758d3bb6b3696ae7d1129419d/inc/saiqueue.h#L280
Where are these attributes coming from?
doc/voq/aggregate_voq_counters.md
Outdated
| admin@cmp217:~$ show queue counters "cmp217-5|asic0|Ethernet24" --voq | ||
| Port Voq Counter/pkts Counter/bytes Drop/pkts Drop/bytes Credit-WD-Del/pkts | ||
| ------------------------- ----- -------------- --------------- ----------- ------------ -------------------- | ||
| cmp217-5|asic0|Ethernet24 VOQ0 54 2700 0 0 0 |
There was a problem hiding this comment.
What are the other filters we can apply for this show command?. Can we filter the output for a Line card or asic in Linecard?
There was a problem hiding this comment.
No other filter can be applied as of now. We can only aggregate counters as per system port.
This document provides general information about the feature aggregate VOQ counters in a distributed VOQ architecture.
This feature has been tracked in #1543
code PRs for tracking
The code pull requests should merge in the order they are mentioned in the table.